Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in kadet prune input handling #982

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Fix typo in kadet prune input handling #982

merged 1 commit into from
Mar 31, 2023

Conversation

ademariag
Copy link
Contributor

@ademariag ademariag commented Mar 30, 2023 •
edited
Loading

Fixes issue with kadet pruning

  kapitan:
    compile:
      - output_path: manifests
        input_type: kadet
        output_type: yml
        prune: false   <------- honour this prune to override the default

Proposed Changes

  • a typo was preventing "prune" to be read from the input definition (see)

@ademariag ademariag added the bug label Mar 30, 2023
@gburiola
Copy link
Contributor

@ademariag I don't get this.

Where is the typo?

And shouldn't the variable be renamed to prune_output or prune_compiled as it's the compiled content that is being pruned right?

@ademariag
Copy link
Contributor Author

ademariag commented Mar 30, 2023 •
edited
Loading

@gburiola this is a typo because I know that the original author (me: #444) intended to use the newly introduced variable instead of prune :)

I agree the name is not great, so I can change it to prune_output

@ademariag ademariag force-pushed the fix-kapitan-kadet-prune branch from dcd110c to 0456342 Compare March 31, 2023 00:35
@uberspot uberspot merged commit 8f01699 into master Mar 31, 2023
@uberspot uberspot deleted the fix-kapitan-kadet-prune branch March 31, 2023 06:34
@ademariag ademariag mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uberspot uberspot uberspot approved these changes

@gburiola gburiola gburiola approved these changes

@adrianchifor adrianchifor Awaiting requested review from adrianchifor

@ramaro ramaro Awaiting requested review from ramaro

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ademariag @gburiola @uberspot